Akshat-Jain opened a new pull request, #17708:
URL: https://github.com/apache/druid/pull/17708
### Description
The `if: ${{ failure() }} || ${{ inputs.artifact_prefix != '' }}` condition
in always seems to be evaluating to `true`, as can be seen here where the
upload artifact step was run even though no prior step failed:
https://github.com/implydata/druid/actions/runs/13199722965/job/36850130824?pr=3053
This is also the reason why this job failed on the weekly cron:
https://github.com/apache/druid/actions/runs/13211720628/job/36886496050
<hr>
This PR has:
- [x] been self-reviewed.
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
