surekhasaharan commented on a change in pull request #7041: Kill all running tasks when the supervisor task is killed URL: https://github.com/apache/incubator-druid/pull/7041#discussion_r258752451
########## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/TaskMonitor.java ########## @@ -84,6 +85,12 @@ private int numRunningTasks; private int numSucceededTasks; private int numFailedTasks; + // This metric is used only for unit tests because the current taskStatus system doesn't track the killed task status. + // Currently, this metric only represents # of killed tasks by ParallelIndexTaskRunner. + // See killAllRunningTasks(), SinglePhaseParallelIndexTaskRunner.run(), and + // SinglePhaseParallelIndexTaskRunner.stopGracefully() + @VisibleForTesting Review comment: I did not understand this annotation here, since `numKilledTasks` is private. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
