kfaraz commented on code in PR #17723:
URL: https://github.com/apache/druid/pull/17723#discussion_r1957222998
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java:
##########
@@ -1887,10 +1887,13 @@ public Response pauseHTTP(
@VisibleForTesting
public Response pause() throws InterruptedException
{
- if (!(status == Status.PAUSED || status == Status.READING)) {
+ // Read the volatile status into a variable so that its value does not
change while the condition is evaluated
+ final Status currentStatus = status;
+ if (!(currentStatus == Status.PAUSED || currentStatus == Status.READING)) {
+ log.error("Cannot pause task: [%s] as it is currently in state: [%s]",
task.getId(), currentStatus);
return Response.status(Response.Status.CONFLICT)
.type(MediaType.TEXT_PLAIN)
- .entity(StringUtils.format("Can't pause, task is not in a
pausable state (state: [%s])", status))
+ .entity(StringUtils.format("Cannot pause task as it is
currently in state: [%s]", currentStatus))
Review Comment:
Updated the message to match Druid interpolation style
```suggestion
.entity(StringUtils.format("Cannot pause task as it is
currently in state[%s]", currentStatus))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
