GWphua commented on PR #17701: URL: https://github.com/apache/druid/pull/17701#issuecomment-2670263644
> Earlier the pod template code was de-serialized and kept in memory only once no ? Now for each invocation of task, the supplier gets called which reads the contents from file no ? Is that correct ? @GWphua ? > > I am kind of on the fence for this. Its easier to debug when stuff is immutable. Earlier I just use to check if the template name is same or not but now templates with same name can be different. Hi @cryptoe, you are right about the logic of how it works. Regarding ease of debugging, it is also possible for the case that you have described: If the user and the cluster both have `podTemplateFile.yaml`, but the contents are different, there may be some confusion. However, I think we can still do debugging by going into the pod and `cat /path/to/podTemplateFile.yaml` to see the template files. The main motivation behind this PR is to allow users to easily configure task pod resources without restarting the Overlord. I also suggest taking a look at "Example 2: Using a ConfigMap to upload the Pod Template file" to easily maintain a single source of truth to allow you to identify issues easier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
