clintropolis commented on code in PR #17741:
URL: https://github.com/apache/druid/pull/17741#discussion_r1964850275
##########
server/src/test/java/org/apache/druid/server/coordinator/duty/CompactSegmentsTest.java:
##########
@@ -2193,18 +2179,21 @@ private void compactSegments(
clientCompactionTaskQuery.getDimensionsSpec().getDimensions()
),
metricsSpec,
- transformSpec,
- ImmutableMap.of(
- "bitmap",
- ImmutableMap.of("type", "roaring"),
- "dimensionCompression",
- "lz4",
- "metricCompression",
- "lz4",
- "longEncoding",
- "longs"
+ clientCompactionTaskQuery.getTransformSpec(),
+ jsonMapper.convertValue(
+ ImmutableMap.of(
+ "bitmap",
+ ImmutableMap.of("type", "roaring"),
+ "dimensionCompression",
+ "lz4",
+ "metricCompression",
+ "lz4",
+ "longEncoding",
+ "longs"
+ ),
+ IndexSpec.class
),
- ImmutableMap.of()
+ jsonMapper.convertValue(ImmutableMap.of(),
GranularitySpec.class)
Review Comment:
yea, I was just leaving these as is to preserve the way stuff was being
tested exactly instead of what they were effectively doing, not sure how useful
that is though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
