kgyrtkirk commented on PR #17757: URL: https://github.com/apache/druid/pull/17757#issuecomment-2684265901
a lot of `DruidQuery` objects are created during planning - that caused to add hacks around it...what kinda causes the confusing state you see... Even in case you have a resulting "query" with a single subquery; that might have still created 100s of `DruidQuery` objects because how things work - it doesn't seem reasonable to apply it to all of them recursively. Since `withPolicies` is fully recursive it creates new objects without questions that might have some adverse effects. If there are a lot of subquery-s that might add some extra weight; but most likely it wouldn't be that visible as other things are doing the same. This was kinda the reason I was asking to make it less connected to `DruidQuery` But I see now that might be a hard ask because `DruidQuery` is also the [contract object](https://github.com/apache/druid/blob/e56d55b4ce576a52d19d0829dde2dbb148acf69b/sql/src/main/java/org/apache/druid/sql/calcite/run/QueryMaker.java#L36) with the execution engines which ties our hands. changing that is on my list :) its ok for now - as it works.... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
