clintropolis opened a new pull request, #17760: URL: https://github.com/apache/druid/pull/17760
Improves exception message when merging `CapabilitiesBasedFormat` in `IndexMergerV9` when faced with mismatched complex types. Prior to this change merging a complex type with a string type for example would create an exception message with a message like `Cannot merge columns of type[someComplex] and [null]` since it was using the complex type name of both types, which will be null for non-complex types. After this change this exception message for complex types will be something like `Cannot merge columns of type[COMPLEX<someComplex>] and [STRING]` since it will now use the type strings. I also modified a merge behavior of `ColumnCapabilities.areDictionaryValuesSorted` and `ColumnCapabilities.areDictionaryValuesUnique` in `CapabilitiesBasedFormat.merge` that probably doesn't really matter since these are computed for query time stuff and they do not actually affect segment persistence but seemed odd behavior considering everything else in the merge, so now it is consistent and uses 'or' instead of 'and'. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
