github-advanced-security[bot] commented on code in PR #17823:
URL: https://github.com/apache/druid/pull/17823#discussion_r2005032961
##########
server/src/test/java/org/apache/druid/query/ResultLevelCachingQueryRunnerTest.java:
##########
@@ -264,6 +275,71 @@
}
}
+ @Test
+ public void testUseCacheAndReleaseResourceFromClient()
+ {
+ final BlockingPool<ByteBuffer> mergePool = new DefaultBlockingPool<>(() ->
ByteBuffer.allocate(1), 1);
+ prepareCluster(10);
+ final Query<Result<TimeseriesResultValue>> query =
timeseriesQuery(BASE_SCHEMA_INFO.getDataInterval());
+ CacheConfig cacheConfig = newCacheConfig(true, true,
DEFAULT_CACHE_ENTRY_MAX_SIZE);
+ final QueryRunner<Result<TimeseriesResultValue>> baseRunner =
cachingClusteredClient.getQueryRunnerForIntervals(query, query.getIntervals());
+ RetryQueryRunner<Result<TimeseriesResultValue>> spyRunner =
Mockito.spy(new RetryQueryRunner<>(
+ baseRunner,
+ cachingClusteredClient::getQueryRunnerForSegments,
+ new RetryQueryRunnerConfig(),
+ objectMapper
+ ));
+ Mockito.doAnswer((Answer<Object>) invocation -> {
+ List<ReferenceCountingResourceHolder<ByteBuffer>> resoruce =
mergePool.takeBatch(1, 1);
+ if (resoruce.isEmpty()) {
+ fail("Resource should not be empty");
+ }
+ Sequence<Result<TimeseriesResultValue>> realSequence =
(Sequence<Result<TimeseriesResultValue>>) invocation.callRealMethod();
+ Closer closer = Closer.create();
+ closer.register(() ->
resoruce.forEach(ReferenceCountingResourceHolder::close));
+ return Sequences.withBaggage(realSequence, closer);
+ }).when(spyRunner).run(ArgumentMatchers.any(), ArgumentMatchers.any());
+
+ final ResultLevelCachingQueryRunner<Result<TimeseriesResultValue>>
queryRunner1 = new ResultLevelCachingQueryRunner<>(
+ spyRunner,
+ conglomerate.getToolChest(query),
+ query,
+ objectMapper,
+ cache,
+ cacheConfig
+ );
+
+ final Sequence<Result<TimeseriesResultValue>> sequence1 = queryRunner1.run(
+ QueryPlus.wrap(query),
+ responseContext()
+ );
+ final List<Result<TimeseriesResultValue>> results1 = sequence1.toList();
+ Assert.assertEquals(0, cache.getStats().getNumHits());
+ Assert.assertEquals(1, cache.getStats().getNumEntries());
+ Assert.assertEquals(1, cache.getStats().getNumMisses());
+
+
+ final Sequence<Result<TimeseriesResultValue>> sequence2 = queryRunner1.run(
+ QueryPlus.wrap(query),
+ responseContext()
+ );
+ final List<Result<TimeseriesResultValue>> results2 = sequence2.toList();
+ Assert.assertEquals(results1, results2);
+ Assert.assertEquals(1, cache.getStats().getNumHits());
+ Assert.assertEquals(1, cache.getStats().getNumEntries());
+ Assert.assertEquals(1, cache.getStats().getNumMisses());
+
+ final Sequence<Result<TimeseriesResultValue>> sequence3 = queryRunner1.run(
+ QueryPlus.wrap(query),
+ responseContext()
+ );
Review Comment:
## Unread local variable
Variable 'Sequence<Result<TimeseriesResultValue>> sequence3' is never read.
[Show more
details](https://github.com/apache/druid/security/code-scanning/8759)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
