cryptoe commented on code in PR #17782: URL: https://github.com/apache/druid/pull/17782#discussion_r2007002370
########## docs/data-management/automatic-compaction.md: ########## @@ -243,11 +243,12 @@ You can run automatic compaction using compaction supervisors on the Overlord ra * Tracked compaction task status to avoid re-compacting an interval repeatedly -To use compaction supervisors, set the following properties in your Overlord runtime properties: - * `druid.supervisor.compaction.enabled` to `true` so that compaction tasks can be run as supervisor tasks - * `druid.supervisor.compaction.engine` to `msq` to specify the MSQ task engine as the compaction engine or to `native` to use the native engine. This is the default engine if the `engine` field is omitted from your compaction config +To use compaction supervisors, update the [compaction dynamic config](../api-reference/automatic-compaction-api.md#update-cluster-level-compaction-config) and set: -Compaction supervisors use the same syntax as auto-compaction using Coordinator duties with one key difference: you submit the auto-compaction as a a supervisor spec. In the spec, set the `type` to `autocompact` and include the auto-compaction config in the `spec`. +* `useSupervisors` to `true` so that compaction tasks can be run as supervisor tasks Review Comment: NVM. I think these are compaction specific endpoints so we donot need the compaction key. Changes LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
