kfaraz commented on code in PR #17785:
URL: https://github.com/apache/druid/pull/17785#discussion_r2013068022
##########
processing/src/main/java/org/apache/druid/common/utils/IdUtils.java:
##########
@@ -167,4 +169,24 @@ public static SegmentId getValidSegmentId(String
dataSource, String serializedSe
return parsedSegmentId;
}
}
+
+ /**
+ * Tries to parse the given serialized ID as {@link SegmentId}s of the given
Review Comment:
Yeah, I guess it would be better to error out on invalid segment IDs.
The only place these can come from are REST APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
