gianm commented on code in PR #17774: URL: https://github.com/apache/druid/pull/17774#discussion_r2022754476
########## processing/src/main/java/org/apache/druid/query/policy/PolicyEnforcer.java: ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.query.policy; + +import com.fasterxml.jackson.annotation.JsonSubTypes; +import com.fasterxml.jackson.annotation.JsonTypeInfo; +import org.apache.druid.guice.annotations.UnstableApi; +import org.apache.druid.query.DataSource; + +/** + * A mechanism for enforcing policies on data sources in Druid queries. + */ +@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = "type", defaultImpl = NoopPolicyEnforcer.class) Review Comment: We should avoid `defaultImpl` in a `@JsonTypeInfo` info line, unless absolutely needed for backwards compatibility. The reason is that when there is a `defaultImpl`, it catches all invalid types (not just missing types), which is weird and confusing behavior. In this case it would mean that if someone misspells the enforcer `type`, or forgets to load an extension, we would silently use the `none` enforcer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
