cryptoe commented on code in PR #17860:
URL: https://github.com/apache/druid/pull/17860#discussion_r2024096434


##########
web-console/src/druid-models/coordinator-dynamic-config/coordinator-dynamic-config.tsx:
##########
@@ -156,6 +157,19 @@ export const COORDINATOR_DYNAMIC_CONFIG_FIELDS: 
Field<CoordinatorDynamicConfig>[
       </>
     ),
   },
+  {
+    name: 'turboLoadingNodes',
+    type: 'string-array',
+    info: (
+      <>
+        List of Historical servers to place in turbo loading mode. These 
servers use a larger
+        thread-pool to load segments faster but at the cost of query 
performance. For servers
+        specified in <Code>turboLoadingNodes</Code>,{' '}
+        <Code>druid.coordinator.loadqueuepeon.http.batchSize</Code> is ignored 
and the coordinator
+        uses the value of the respective <Code>numLoadingThreads</Code> 
instead.

Review Comment:
   ```suggestion
           uses the value of the respective <Code>numLoadingThreads</Code> 
instead. Please use this config with caution. All servers should eventually be 
removed from this list once the segment loading on the respective historicals 
is finished.
   ```



##########
web-console/src/druid-models/coordinator-dynamic-config/coordinator-dynamic-config.tsx:
##########
@@ -156,6 +157,19 @@ export const COORDINATOR_DYNAMIC_CONFIG_FIELDS: 
Field<CoordinatorDynamicConfig>[
       </>
     ),
   },
+  {
+    name: 'turboLoadingNodes',
+    type: 'string-array',
+    info: (
+      <>
+        List of Historical servers to place in turbo loading mode. These 
servers use a larger

Review Comment:
   ```suggestion
           [Experimental] List of Historical servers to place in turbo loading 
mode. These servers use a larger
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to