Akshat-Jain commented on code in PR #17867:
URL: https://github.com/apache/druid/pull/17867#discussion_r2029036319
##########
integration-tests/src/main/java/org/apache/druid/testing/guice/DruidTestModule.java:
##########
@@ -85,6 +85,8 @@ public HttpClient getHttpClient(
@ManageLifecycle
public ServiceEmitter getServiceEmitter(Supplier<LoggingEmitterConfig>
config, ObjectMapper jsonMapper)
Review Comment:
Can both the params also be removed now?
##########
integration-tests/src/test/java/org/apache/druid/tests/coordinator/duty/ITAutoCompactionLockContentionTest.java:
##########
@@ -324,32 +324,12 @@ private void ensureCompactionTaskCount(int expectedCount)
*/
private int getNumberOfCompletedCompactionTasks()
{
- List<TaskResponseObject> incompleteTasks = indexer
- .getUncompletedTasksForDataSource(fullDatasourceName);
List<TaskResponseObject> completeTasks = indexer
.getCompleteTasksForDataSource(fullDatasourceName);
- printTasks(incompleteTasks, "Incomplete");
- printTasks(completeTasks, "Complete");
-
return (int) completeTasks.stream().filter(this::isCompactionTask).count();
}
- private void printTasks(List<TaskResponseObject> tasks, String taskState)
Review Comment:
Are these not helpful from a debugging point of view? 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
