kfaraz commented on PR #17749: URL: https://github.com/apache/druid/pull/17749#issuecomment-2783599925
> Note that this solution will not allow us to differentiate between tasks in Kubernetes. However, we can still see our tasks and their corresponding taskID via the Web Console. Note: My approach involves changing the method of K8sTaskId, prompting change in a lot other classes. This may not be the best way, please advise if there's a more elegant solution. Yeah, @GWphua , I am not sure if this is a real improvement over what we had earlier. With a prefix specified, all task pods launched by a cluster will end up looking the same (except for the hash part, which is not exactly human readable). It would be difficult to identify the pod for any given Druid task ID. Plus, requiring users to specify a prefix just to be able to tell pods apart seems undesirable to me. That said, using the substring of the task name was not all that great either. I am not sure what a better alternative would be, but will try to give it some more thought. Side note: IIUC from the changes, this shouldn't have any rolling upgrade implications, i.e. task pods launched by an Overlord where the `k8sTaskPodNamePrefix` was not specified can still be detected by an Overlord where this config has been specified (or an Overlord where the value of the config has been updated). @GWphua , could you please confirm if this is actually the case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
