kfaraz commented on code in PR #17916:
URL: https://github.com/apache/druid/pull/17916#discussion_r2043978782
##########
extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authorization/endpoint/BasicAuthorizerResource.java:
##########
@@ -665,7 +673,11 @@ public Response authorizerGroupMappingUpdateListener(
)
{
authValidator.validateAuthorizerName(authorizerName);
- return
resourceHandler.authorizerGroupMappingUpdateListener(authorizerName,
serializedGroupMappingAndRoleMap);
+
+ final Response response =
resourceHandler.authorizerGroupMappingUpdateListener(authorizerName,
serializedGroupMappingAndRoleMap);
+ performAuditIfSuccess(authorizerName, req, response, "Update group
mappings for authorizer[%s]", authorizerName);
Review Comment:
Looking at this, I think we should include the authorizer name in the other
audit messages in this class too. We can do it in a follow up PR or this one
itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
