gianm commented on code in PR #17917:
URL: https://github.com/apache/druid/pull/17917#discussion_r2046114636


##########
indexing-service/src/main/java/org/apache/druid/indexing/common/TaskToolbox.java:
##########
@@ -287,6 +295,11 @@ public QueryRunnerFactoryConglomerate 
getQueryRunnerFactoryConglomerate()
     return queryRunnerFactoryConglomerateProvider.get();
   }
 
+  public DruidProcessingConfig getProcessingConfig()

Review Comment:
   I'm not sure, I don't remember if a `Provider` with nothing to provide 
returns `null` or throws an exception. Fwiw, the reason this isn't annotated is 
because I was copying the design of `getQueryRunnerFactoryConglomerate()`, 
which also isn't annotated. I figured it was a good one to copy because like 
`DruidProcessingConfig` it is also query-related.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to