FrankChen021 opened a new pull request, #17937:
URL: https://github.com/apache/druid/pull/17937

   A part of #17769.
   
   
   ### Description
   
   Allow raw sql in the HTTP body on http endpoints. This helps reduce the 
client side complexity which require users to do character escape when the SQL 
in placed in the JSON document. The following example demonstrates the usage:
   
   ```bash
   echo 'SELECT 1' | curl -X POST "http://localhost:8082/druid/v2/sql"; --data @-
   ```
   
   #### Release note
   
   Druid now supports raw text format SQL on `/druid/v2/sql` endpoint. The 
content in the HTTP body of a HTTP request which does not set `Content-Type` to 
`application/json` will be treated as a raw sql text.
   
   
   ##### Key changed/added classes in this PR
   1. Only HTTP requests with `Content-Type: application/json` will be parsed 
as traditional JSON format SQL
   2. All other HTTP requests including those with empty Content-Type will be 
parsed as raw SQL
   3. Router also supports raw text SQL, but when it forwards query to brokers, 
it uses the JSON format for simplicity implementation
   
   
   <hr>
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not 
all of these items apply to every PR. Remove the items which are not done or 
not relevant to the PR. None of the items from the checklist below are strictly 
necessary, but it would be very helpful if you at least self-review the PR. -->
   
   This PR has:
   
   - [x] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [x] added documentation for new or modified features or behaviors.
   - [x] a release note entry in the PR description.
   - [x] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [x] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [x] added integration tests.
   - [x] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to