github-advanced-security[bot] commented on code in PR #17948:
URL: https://github.com/apache/druid/pull/17948#discussion_r2060055692
##########
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/test/MSQTestOverlordServiceClient.java:
##########
@@ -138,18 +183,52 @@
}
finally {
if (queryListener != null && queryListener.reportMap != null) {
- reports.put(controller.queryId(), queryListener.getReportMap());
+ testTaskDetails.report = queryListener.getReportMap();
}
}
}
+ private static final Logger LOG = new
Logger(MSQTestOverlordServiceClient.class);
+
+
+ private MSQTestTaskDetails registerTestTask(String taskId)
+ {
+ MSQTestTaskDetails details = taskDetailsByTaskId.get(taskId);
+ if (details!= null) {
+ LOG.warn("There is an un-closed taskId which will be overwritten;
closing implicitly");
+ details.close();
+ }
+ details = new MSQTestTaskDetails(taskId);
+ taskDetailsByTaskId.put(taskId, details);
+ return details;
+ }
+
+ private void registerController(String queryId, MSQTestTaskDetails
msqTestTaskDetails)
+ {
+ MSQTestTaskDetails old = taskDetailsByQueryId.get(queryId);
+ if (old != null) {
+ throw DruidException.defensive("There is an existing queryId {}!",
queryId);
Review Comment:
## Unused format argument
This format call refers to 0 argument(s) but supplies 1 argument(s).
[Show more
details](https://github.com/apache/druid/security/code-scanning/8933)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
