github-advanced-security[bot] commented on code in PR #17954:
URL: https://github.com/apache/druid/pull/17954#discussion_r2065436948
##########
processing/src/main/java/org/apache/druid/frame/segment/FrameSegment.java:
##########
@@ -43,6 +43,15 @@
private final FrameReader frameReader;
private final SegmentId segmentId;
+ public FrameSegment(Frame frame, FrameReader frameReader, String unused)
+ {
+ this(frame, frameReader, SegmentId.simple(SegmentId.DataSourceType.FRAME));
Review Comment:
## Deprecated method or constructor invocation
Invoking [FrameSegment.FrameSegment](1) should be avoided because it has
been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/8935)
##########
processing/src/main/java/org/apache/druid/query/lookup/LookupSegment.java:
##########
@@ -38,16 +38,17 @@
*/
public class LookupSegment extends RowBasedSegment<Map.Entry<String, String>>
{
+ public static final SegmentId SEGMENT_ID =
SegmentId.simple(SegmentId.DataSourceType.LOOKUP);
private static final RowSignature ROW_SIGNATURE =
RowSignature.builder()
.add(LookupColumnSelectorFactory.KEY_COLUMN,
ColumnType.STRING)
.add(LookupColumnSelectorFactory.VALUE_COLUMN,
ColumnType.STRING)
.build();
- public LookupSegment(final String lookupName, final LookupExtractorFactory
lookupExtractorFactory)
+ public LookupSegment(final String unused, final LookupExtractorFactory
lookupExtractorFactory)
Review Comment:
## Useless parameter
The parameter 'unused' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/8937)
##########
processing/src/main/java/org/apache/druid/frame/segment/FrameSegment.java:
##########
@@ -43,6 +43,15 @@
private final FrameReader frameReader;
private final SegmentId segmentId;
+ public FrameSegment(Frame frame, FrameReader frameReader, String unused)
Review Comment:
## Useless parameter
The parameter 'unused' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/8936)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
