winsmith opened a new pull request, #17963: URL: https://github.com/apache/druid/pull/17963
Fixes https://github.com/apache/druid/issues/1796 ### Description This PR updates the community extension `druid-redis-cache` so that it can also connect to Redis Clusters with TLS enabled. This is awesome because AWS ElastiCache has TLS enabled by default and it's not always possible to disable that setting. It adds an `enableTls` property to `RedisCacheConfig` and use its contents for Jedis’ `ssl` parameter. It also updates the docs to list the new parameter. While I'm reasonably proficient with other languages, I haven't touched Java for a long while, so I'd be very open to improvement requests. I tried to stay as close to other implementations such as the one for `MemcachedCacheConfig` as possible. #### Release note Add TLS support to the `druid-redis-cache` community extension. <hr> This PR has: - [x] been self-reviewed. - [x] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) - [x] added documentation for new or modified features or behaviors. - [x] a release note entry in the PR description. - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
