kfaraz commented on code in PR #17964:
URL: https://github.com/apache/druid/pull/17964#discussion_r2068808386
##########
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java:
##########
@@ -2194,54 +2193,58 @@ protected SegmentPublishResult
updateDataSourceMetadataWithHandle(
Hashing.sha1().hashBytes(newCommitMetadataBytes).asBytes()
);
- final SegmentPublishResult retVal;
+ final SegmentPublishResult publishResult;
if (oldCommitMetadataBytesFromDb == null) {
// SELECT -> INSERT can fail due to races; callers must be prepared to
retry.
- final int numRows = transaction.getHandle().createStatement(
- StringUtils.format(
- "INSERT INTO %s (dataSource, created_date,
commit_metadata_payload, commit_metadata_sha1) "
- + "VALUES (:dataSource, :created_date, :commit_metadata_payload,
:commit_metadata_sha1)",
- dbTables.getDataSourceTable()
- )
- )
- .bind("dataSource", dataSource)
- .bind("created_date",
DateTimes.nowUtc().toString())
- .bind("commit_metadata_payload",
newCommitMetadataBytes)
- .bind("commit_metadata_sha1",
newCommitMetadataSha1)
- .execute();
-
- retVal = numRows == 1
+ final String insertSql = StringUtils.format(
+ "INSERT INTO %s (dataSource, created_date, commit_metadata_payload,
commit_metadata_sha1) "
+ + "VALUES (:dataSource, :created_date, :commit_metadata_payload,
:commit_metadata_sha1)",
+ dbTables.getDataSourceTable()
+ );
+ final int numRows = transaction.getHandle().createStatement(insertSql)
+ .bind("dataSource", dataSource)
+ .bind("created_date",
DateTimes.nowUtc().toString())
+ .bind("commit_metadata_payload",
newCommitMetadataBytes)
+ .bind("commit_metadata_sha1",
newCommitMetadataSha1)
+ .execute();
+
+ publishResult = numRows == 1
? SegmentPublishResult.ok(Set.of())
- : SegmentPublishResult.retryableFailure("Failed to insert metadata
for datasource[%s]", dataSource);
+ : SegmentPublishResult.retryableFailure("Insert failed", dataSource);
Review Comment:
```suggestion
: SegmentPublishResult.retryableFailure("Insert failed");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
