kfaraz commented on code in PR #17971:
URL: https://github.com/apache/druid/pull/17971#discussion_r2071058136
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -543,9 +544,27 @@ private boolean changeTaskCount(int desiredActiveTaskCount)
desiredActiveTaskCount,
dataSource
);
+ final long scaleActionStart = System.currentTimeMillis();
gracefulShutdownInternal();
changeTaskCountInIOConfig(desiredActiveTaskCount);
clearAllocationInfo();
+ final long scaleActionEnd = System.currentTimeMillis();
+ try {
Review Comment:
Yeah, weird. I guess it was done as a safety measure to ensure that the
supervisor thread doesn't stall even if metric emissions fail (which should not
throw an exception .
It is definitely redundant since the `Emitter.emit` contract already says
that it cannot throw exceptions and must return immediately.
But we can leave it for now. I can take a look at all the metric emissions
later.
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -543,9 +544,27 @@ private boolean changeTaskCount(int desiredActiveTaskCount)
desiredActiveTaskCount,
dataSource
);
+ final long scaleActionStart = System.currentTimeMillis();
gracefulShutdownInternal();
changeTaskCountInIOConfig(desiredActiveTaskCount);
clearAllocationInfo();
+ final long scaleActionEnd = System.currentTimeMillis();
+ try {
Review Comment:
Yeah, weird. I guess it was done as a safety measure to ensure that the
supervisor thread doesn't stall even if metric emissions fail (which should not
throw an exception .
It is definitely redundant since the `Emitter.emit` contract already says
that it cannot throw exceptions and must return immediately.
But we can leave it for now. I can take a look at all the metric emissions
in this later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
