abhishekrb19 opened a new pull request, #17974:
URL: https://github.com/apache/druid/pull/17974

   This is a follow-up patch to https://github.com/apache/druid/pull/17894 that 
adds support for honoring the query context for `EXPLAIN PLAN` queries via 
`SET` statements.
   
   
   #### Description:
   - `EXPLAIN PLAN` queries were ignoring the query context parameters from 
`SET` statements.
   - This was because the planner config was eagerly built _before_ the `SET` 
statements from the SQL query were processed and the query context extracted in 
`processStatementList`.
   - With this patch, `processStatementList` overrides the planner config in 
the end. In order to do this override, the field is made non-final (similar to 
other non-final mutable members in `PlannerContext`).
   - Adds a couple of tests for explain plan on select and insert queries.
   
   This PR has:
   
   - [x] been self-reviewed.
   - [x] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [x] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to