clintropolis opened a new pull request, #17977:
URL: https://github.com/apache/druid/pull/17977
### Description
changes:
* remove `Segment#asStorageAdapter`, it was deprecated previously and not
used for anything
* transition all callers of `Segment` methods `asCursorFactory()` and
`asQueryableIndex()` to use `as(CursorFactory.class)` and
`as(QueryableIndex.class)`
* remove default implementation of the `as` method on `Segment`, it is now
required
* remove `asCursorFactory` and `asQueryableIndex` from `Segment`
#### Release note
(for developers)
The methods `asCursorFactory`, `asQueryableIndex` have been removed from the
`Segment` interface, in favor of using `as(CursorFactory.class)` and
`as(QueryableIndex.class)`. Additionally, the deprecated method
`asStorageAdapter` has also been removed from `Segment`. Lastly, the `Segment`
interface method `as` no longer has a default implementation, and must be
manually implemented. Previously the default `as` method implementation
delegated to `asCursorFactory` and `asQueryableIndex` for providing
`CursorFactory.class` and `QueryableIndex.class` respectively.
These changes simplify the `Segment` interface and should reduce confusion
for both callers and implementors, as well as make it easier to keep track of
which segments provide what objects via the `as` method.
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
