capistrant commented on code in PR #17955:
URL: https://github.com/apache/druid/pull/17955#discussion_r2079548777
##########
server/src/main/java/org/apache/druid/indexing/overlord/supervisor/SupervisorSpec.java:
##########
@@ -100,4 +100,16 @@ default Set<ResourceAction> getInputSourceResources()
throws UnsupportedOperatio
* @return source like stream or topic name
*/
String getSource();
+
+ /**
+ * Checks if a proposed evolution of the supervisor spec is allowed.
+ * <p>
+ * SupervisorSpec `that` is proposed to replace the current supervisor spec.
Implementations of this method determine
+ * if the system should allow this evolution.
+ * </p>
+ *
+ * @param that the proposed supervisor spec
+ * @throws IllegalArgumentException if the evolution is not allowed
+ */
+ void validateProposedSpecEvolution(SupervisorSpec that) throws
IllegalArgumentException;
Review Comment:
Thanks for that default tip, cleaned up a ton :) also fixed the Exception
type to use DruidException and made an attempt at rename
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
