capistrant commented on code in PR #17959:
URL: https://github.com/apache/druid/pull/17959#discussion_r2079835471
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskLockbox.java:
##########
@@ -1259,30 +1259,45 @@ private void cleanupUpgradeAndPendingSegments(Task task)
);
}
- // Clean up pending segments associated with an APPEND task
- if (task instanceof PendingSegmentAllocatingTask) {
- final String taskAllocatorId = ((PendingSegmentAllocatingTask)
task).getTaskAllocatorId();
- if (activeAllocatorIdToTaskIds.containsKey(taskAllocatorId)) {
- final Set<String> taskIdsForSameAllocator =
activeAllocatorIdToTaskIds.get(taskAllocatorId);
- taskIdsForSameAllocator.remove(task.getId());
-
- if (taskIdsForSameAllocator.isEmpty()) {
- final int pendingSegmentsDeleted = metadataStorageCoordinator
- .deletePendingSegmentsForTaskAllocatorId(task.getDataSource(),
taskAllocatorId);
- log.info(
- "Deleted [%d] entries from pendingSegments table for
taskAllocatorId[%s].",
- pendingSegmentsDeleted, taskAllocatorId
- );
- }
- activeAllocatorIdToTaskIds.remove(taskAllocatorId);
- }
- }
+ cleanupPendingSegments(task);
}
catch (Exception e) {
log.warn(e, "Failure cleaning up upgradeSegments or pendingSegments
tables.");
}
}
+ /**
+ * Cleans up pending segments associated with an APPEND task.
+ */
+ protected void cleanupPendingSegments(Task task)
+ {
+ if (!(task instanceof PendingSegmentAllocatingTask)) {
+ return;
+ }
+
+ giant.lock();
Review Comment:
Thanks for filling me in!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
