cryptoe commented on code in PR #17967:
URL: https://github.com/apache/druid/pull/17967#discussion_r2084390760
##########
server/src/main/java/org/apache/druid/segment/metadata/CoordinatorSegmentMetadataCache.java:
##########
@@ -502,13 +508,17 @@ public void refresh(final Set<SegmentId>
segmentsToRefresh, final Set<String> da
dataSourcesNeedingRebuild.clear();
}
- log.debug("Datasources to rebuild are [%s]", dataSourcesToRebuild);
+ log.debug("Re-building schema for datasources[%s].", dataSourcesToRebuild);
// Rebuild the datasources.
for (String dataSource : dataSourcesToRebuild) {
final RowSignature rowSignature =
buildDataSourceRowSignature(dataSource);
if (rowSignature == null) {
- log.info("RowSignature null for dataSource [%s], implying that it no
longer exists. All metadata removed.", dataSource);
+ log.info(
+ "Datasource[%s] no longer exists as its row signature is [null]."
+ + " Removing all cached metadata.",
Review Comment:
We should also mention that removing cached metadata for this data source
only.
##########
docs/operations/metrics.md:
##########
@@ -421,17 +421,16 @@ These metrics are emitted by the Druid Coordinator in
every run of the correspon
|`serverview/sync/healthy`|Sync status of the Coordinator with a
segment-loading server such as a Historical or Peon. Emitted only when
[HTTP-based server view](../configuration/index.md#segment-management) is
enabled. You can use this metric in conjunction with
`serverview/sync/unstableTime` to debug slow startup of the
Coordinator.|`server`, `tier`|1 for fully synced servers, 0 otherwise|
|`serverview/sync/unstableTime`|Time in milliseconds for which the Coordinator
has been failing to sync with a segment-loading server. Emitted only when
[HTTP-based server view](../configuration/index.md#segment-management) is
enabled.|`server`, `tier`|Not emitted for synced servers.|
|`metadatacache/init/time`|Time taken to initialize the coordinator segment
metadata cache.||Depends on the number of segments.|
-|`metadatacache/refresh/count`|Number of segments to refresh in coordinator
segment metadata cache.|`dataSource`||
-|`metadatacache/refresh/time`|Time taken to refresh segments in coordinator
segment metadata cache.|`dataSource`||
-|`metadatacache/backfill/count`|Number of segments for which schema was back
filled in the database.|`dataSource`||
-|`metadatacache/realtimeSegmentSchema/count`|Number of realtime segments for
which schema is cached.||Depends on the number of realtime segments in the
cluster.|
-|`metadatacache/finalizedSegmentMetadata/count`|Number of finalized segments
for which schema metadata is cached.||Depends on the number of segments in the
cluster.|
-|`metadatacache/finalizedSchemaPayload/count`|Number of finalized segment
schema cached.||Depends on the number of distinct schema in the cluster.|
-|`metadatacache/temporaryMetadataQueryResults/count`|Number of segments for
which schema was fetched by executing segment metadata query.||Eventually it
should be 0.|
-|`metadatacache/temporaryPublishedMetadataQueryResults/count`|Number of
segments for which schema is cached after back filling in the database.||This
value gets reset after each database poll. Eventually it should be 0.|
Review Comment:
What is the equivalent of this metric ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
