cryptoe commented on code in PR #18018:
URL: https://github.com/apache/druid/pull/18018#discussion_r2096799719
##########
processing/src/main/java/org/apache/druid/query/policy/PolicyEnforcer.java:
##########
@@ -77,14 +78,18 @@ default void validateOrElseThrow(TableDataSource ds, Policy
policy) throws Druid
*/
default void validateOrElseThrow(ReferenceCountingSegment segment, Policy
policy) throws DruidException
{
- // Validation will always fail on lookups, external, and inline segments,
because they will not have policies applied (except for NoopPolicyEnforcer).
- // This is a temporary solution since we don't have a perfect way to
identify segments that are backed by a regular table yet.
+ SegmentId segmentId = segment.getId();
+ // SegmentId is null if the segment is not table based, or is already
closed
Review Comment:
Just wanted to understand what does segment close mean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
