Akshat-Jain commented on code in PR #18022:
URL: https://github.com/apache/druid/pull/18022#discussion_r2100288402
##########
indexing-service/src/test/java/org/apache/druid/indexing/overlord/TaskQueueConcurrencyTest.java:
##########
Review Comment:
Unrelated to the changes of this PR:
I tried running `TaskQueueConcurrencyTest` n times (until failure), and
noticed that 2 tests are failing on the 2nd run:
1. `test_manageQueuedTasks_blocks_shutdown_forSameTaskId`
```
Expected :Optional.of(TaskStatus{id=t2, status=RUNNING, duration=-1,
errorMsg=null})
Actual :Optional.of(TaskStatus{id=t2, status=SUCCESS, duration=-1,
errorMsg=null})
```
2. `test_syncFromStorage_blocks_add_forSameTaskId`
```
Expected :Optional.absent()
Actual :Optional.of(AbstractTask{id='t2', groupId='t2',
taskResource=TaskResource{availabilityGroup='t2', requiredCapacity=1},
dataSource='wiki', context={forceTimeChunkLock=true,
useLineageBasedSegmentAllocation=true}})
```
These tests were added in the previous PR, hence they shouldn't block this
PR. But can you confirm that the above behaviour is expected and is just an
intricacy of the test file implementation, and doesn't indicate any actual bug
in the logic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
