clintropolis opened a new pull request, #18029:
URL: https://github.com/apache/druid/pull/18029
### Description
Fixes a bug that can happen when a cursor is reset where the offset contains
an OR filter bundle that contains 'partial index' value matchers (where the
value matcher consists of one or more value matchers that are actually backed
by iterators of the index bitmap). These index backed value matchers are
stateful and assume that the offset will be advanced in order, and so must be
reset if the underlying offset goes 'backwards' (e.g. from cursor reset).
The added tests fail without the changes in this PR, and also modified
`BaseFilterTest` to have some cursor resets involved before collecting the
values to try to prevent and help catch any other similar lurking issues.
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
