jtuglu-netflix commented on code in PR #18031:
URL: https://github.com/apache/druid/pull/18031#discussion_r2105547304
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java:
##########
@@ -958,6 +963,7 @@ public Map<String, Long> getWaitingTaskCount()
.collect(Collectors.toSet());
return activeTasks.values().stream()
Review Comment:
One other point – .values() returns a mutable reference on the underlying
map. Not sure if this is intended, or whether we want to take a copy before
iterating over it. I see this pattern is done in a few places elsewhere as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
