vogievetsky commented on issue #17628: URL: https://github.com/apache/druid/issues/17628#issuecomment-2906839393
Sorry it took me a while to get around to responding to this issue. I somehow missed it. I am planning on upgrading the autocomplete based on the feedback in this issue. Here are my thoughts: > Numerals should not be candidate for autocompletion 100% agree. This was actually fixed in https://github.com/apache/druid/pull/16586/files#diff-71a7ad6a5ecf4d541e559dcff8be182e9cdbf75f353284272b36e8bf6542e22cR190 so if you upgrade to Druid 31 or later this is done. > Inside of double quote "" blocks, function names should not be candidate for autocompletion: datasource and field names only > Inside of single quote '' blocks, should not be candidate for autocompletion Agree. That will be a huge improvement. I am working on his right now as a direct result of this issue. > Other common / completed phrases such as NULL and "count" should not be candidate for autocompletion I think this can be addressed by tweaking the scores of the completions. Like a full match should always be the highest score. Specifically I 100% agree that typing `IS NOT NULL (Enter)` should not autocomplete to `IS NOT NULLIF` in this case it would be solved if the `NULL` completion was scored higher due to being a perfect match. > "enter" shouldn't trigger an auto-complete This one I do not agree with. Enter appears to be a standard autocomplete trigger. Specifically it is a trigger in WebStorm/InteliJ, VSCode, and even in this window where I am typing right now @JRobTS (I just typed your handle by typing `@`, `J`, `(enter)`). I think you are saying that because of all the other issues in autocomplete. Let's see if we can make autocomplete work so well that you won't even mind having Enter be a trigger. Challenge accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
