cryptoe commented on code in PR #18033:
URL: https://github.com/apache/druid/pull/18033#discussion_r2108923316
##########
services/src/main/java/org/apache/druid/cli/CliOverlord.java:
##########
@@ -460,9 +460,30 @@ private void configureOverlordHelpers(Binder binder)
);
}
+
/**
+ * Currenlty, the resource paths of the jersery resources on the overlord
start with
+ * <ol>
+ * <li>/druid/indexer/v1</li>
+ * <li>/druid-internal/v1</li>
+ * </ol>
+ * <p>
+ * As QOS filtering is enabled on overlord requests, we need to update the
QOS filter paths in
+ * {@link
org.apache.druid.cli.CliOverlord#addQOSFiltering(ServletContextHandler, int)}
when a new jersey resource is added.
*/
- private static class OverlordJettyServerInitializer implements
JettyServerInitializer
+ private static void addOverlordJerseyResources(Binder binder)
Review Comment:
Since we donot have the exact thread pool handy, at the time of binding we
can probably not do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
