kfaraz commented on PR #13967: URL: https://github.com/apache/druid/pull/13967#issuecomment-2914753523
@abhishekrb19 , IIRC, there wasn't anything fundamentally wrong with the approach here, but the interest diminished over time and we never got around to finishing it. To merge this PR, we would need the following: - Resolve all merge conflicts - Ensure that CI passes - Ensure that all new features are behind a feature flag and none of the existing code paths are affected - Add sufficient unit tests and at least one integration test for the new feature - Get 2 approvals Unfortunately, I currently don't have the bandwidth to take this up. I will be happy to do a review though if you or anyone else can tick off the above items. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
