kfaraz commented on code in PR #18028:
URL: https://github.com/apache/druid/pull/18028#discussion_r2115137430
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/KillUnusedSegmentsTask.java:
##########
@@ -385,6 +413,10 @@ private List<DataSegment> getKillableSegments(
response.getUpgradedToSegmentIds().forEach((parent, children) -> {
if (!CollectionUtils.isNullOrEmpty(children)) {
// Do not kill segment if its parent or any of its siblings still
exist in metadata store
+ LOG.warn(
+ "Skipping kill of segments[%s] as its load spec is also used
by segment IDs[%s].",
+ parentIdToUnusedSegments.get(parent), children
+ );
parentIdToUnusedSegments.remove(parent);
Review Comment:
Is it okay to postpone the skip metric for now?
I intend to touch this part of the code anyway in a follow up PR for log
improvements in the `DataSegmentKiller` interface (details in the PR
description above).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
