jtuglu-netflix commented on code in PR #18060:
URL: https://github.com/apache/druid/pull/18060#discussion_r2119963021
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java:
##########
@@ -443,8 +447,13 @@ private void startPendingTaskOnRunner(TaskEntry entry,
ListenableFuture<TaskStat
e.getMessage()
);
}
+ statusUpdatesInQueue.incrementAndGet();
+
TaskStatus taskStatus = TaskStatus.failure(task.getId(),
errorMessage);
- notifyStatus(entry, taskStatus, taskStatus.getErrorMsg());
+ notifyCompletedStatus(entry, taskStatus, taskStatus.getErrorMsg());
+
+ statusUpdatesInQueue.decrementAndGet();
+ handledStatusUpdates.incrementAndGet();
Review Comment:
Why not? It's a status update change and should be recorded as such I feel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
