nozjkoitop commented on code in PR #18039:
URL: https://github.com/apache/druid/pull/18039#discussion_r2121085086
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexPhaseRunner.java:
##########
@@ -472,4 +474,18 @@ int getAndIncrementNextSpecId()
{
return nextSpecId++;
}
+
+ private long getSubtaskTimeoutMillisFromContext()
+ {
+ if (context.isEmpty()) {
+ return Tasks.DEFAULT_SUB_TASK_TIMEOUT_MILLIS;
+ }
+
+ Object raw = context.getOrDefault(
+ Tasks.SUB_TASK_TIMEOUT_KEY,
+ Tasks.DEFAULT_SUB_TASK_TIMEOUT_MILLIS
+ );
+
+ return (raw instanceof Number) ? ((Number) raw).longValue() :
Tasks.DEFAULT_SUB_TASK_TIMEOUT_MILLIS;
Review Comment:
In terms of <String, Object> map we can receive a CCE on the Integer value,
so i'd go with the cast to number here
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexTuningConfig.java:
##########
@@ -48,6 +48,7 @@ public class ParallelIndexTuningConfig extends
IndexTuningConfig
private static final int DEFAULT_MAX_NUM_SEGMENTS_TO_MERGE = 100;
private static final int DEFAULT_TOTAL_NUM_MERGE_TASKS = 10;
private static final int DEFAULT_MAX_ALLOWED_LOCK_COUNT = -1;
+ private static final int DEFAULT_SUBTASK_TIMEOUT = 0;
Review Comment:
Thanks for noticing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
