abhishekrb19 commented on code in PR #18025: URL: https://github.com/apache/druid/pull/18025#discussion_r2125731877
########## integration-tests/src/main/java/org/apache/druid/server/coordination/ServerManagerForQueryErrorTest.java: ########## @@ -59,14 +59,21 @@ /** * This server manager is designed to test various query failures. - * - * - Missing segments. A segment can be missing during a query if a historical drops the segment + * <ul> + * <li> Missing segments. A segment can be missing during a query if a historical drops the segment Review Comment: yeah, agreed on keeping the old and new IT frameworks consistent. That said, I couldn’t get the ITs to run reliably on my laptop, I spent about an hour or so on the setup and eventually gave up relying on CI to validate the IT changes instead. Would it be okay to punt on this for now? I can add a comment in the new framework, but mainly wanted to make sure there's at least an IT covering this bug fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
