adarshsanjeev commented on code in PR #18076:
URL: https://github.com/apache/druid/pull/18076#discussion_r2132328609


##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/DataServerQueryHandler.java:
##########
@@ -300,16 +295,17 @@ private List<DataServerRequestDescriptor> 
createNextPendingRequests(
       if 
(segmentLoadInfo.getSegment().toDescriptor().equals(segmentDescriptorWithFullInterval))
 {
         Set<DruidServerMetadata> servers = segmentLoadInfo.getServers()
                                                           .stream()
-                                                          
.filter(druidServerMetadata -> includeSegmentSource.getUsedServerTypes()
-                                                                               
                              .contains(druidServerMetadata.getType()))
+                                                          
.filter(druidServerMetadata -> SegmentSource.REALTIME.getUsedServerTypes()

Review Comment:
   Changed! This one instance should probably remain as `REALTIME`, not a 
default value. This part of the code is common to both and should only be 
called if realtime segments are queried.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to