weishiuntsai opened a new pull request, #18104:
URL: https://github.com/apache/druid/pull/18104

   ### Description
   
   This PR makes the existing quidem tests run on Dart as well.  The last fix 
https://github.com/apache/druid/pull/18088 makes this possible now.  There are 
no new queries added; this change just allows the existing queries to run on 
the Dart engine along with sql-native and MSQ.
   
   This PR also includes a couple of minor cleanups:
   - remove `!set dartQueryId 00000000-0000-0000-0000-000000000000`, which is 
no longer needed.
   - merge some identical iq files from different engines back to one using 
`AllDruidEnginesComponentSupplier`.
   
   This PR has:
   
   - [X] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] a release note entry in the PR description.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to