gianm commented on PR #18102: URL: https://github.com/apache/druid/pull/18102#issuecomment-2959750727
> nice 👍 > > `freshCopy` feels kind of weird, but I can't really think of a cleaner way to do it, and making a factory thing or whatever seems like overkill, so 🤷 It is kind of weird, but that's what you get when you have mutable data structures. Btw, I did look for a way to do a deep clone of the `SqlNode` (rather than re-parsing) but didn't find a good one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
