kfaraz commented on PR #18147: URL: https://github.com/apache/druid/pull/18147#issuecomment-2979598062
Thanks, @abhishekagarwal87 ! An existing test is already using the Kafka extension as a proof-of-concept. But I am currently evaluating two alternatives: #### Option A: Keep the test framework in a separate module `simulation-tests` - Currently implemented in this PR - All simulation tests would live in this module itself - When we want to write a simulation test for an extension, say Kinesis indexing service, `simulation-tests` module would need to depend on that extension. Pros: - All tests live in one module #### Option B: Keep the test framework in `services/test` package - This is highest level Druid core module containing the `Cli*` runnables - Write simulations for core Druid in `services/test` itself - Provide an SDK and expose APIs for extensions to define their own cluster resources e.g. Kafka server (embedded or otherwise) - Extensions can then depend on `services/test` and write out their simulations in their own modules Pros: - More extensible and maintainable in the long run - Keep the simulation tests in the same package as the code being tested - Simulations count towards Jacoco coverage for extensions - So, I will most likely proceed with Option B. What are your thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
