jtuglu-netflix commented on code in PR #18161:
URL: https://github.com/apache/druid/pull/18161#discussion_r2157826375
##########
server/src/main/java/org/apache/druid/server/coordinator/loading/SegmentLoadQueueManager.java:
##########
@@ -126,7 +126,7 @@ public boolean moveSegment(
&& (taskMaster.isHttpLoading()
||
serverInventoryView.isSegmentLoadedByServer(serverNameB, segment))) {
peonA.unmarkSegmentToDrop(segment);
- peonA.dropSegment(segment, moveFinishCallback);
Review Comment:
Yeah, I think you're right regarding the ordering. I also think there's a
reason the internal peon method is called, given it does something with the
callback. I'll switch the ordering and leave the `peonA.dropSegment` as-is for
now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
