kfaraz commented on code in PR #18163:
URL: https://github.com/apache/druid/pull/18163#discussion_r2161664094
##########
extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisorTest.java:
##########
@@ -5209,6 +5283,97 @@ private void addMoreEvents(int numEventsPerPartition,
int num_partitions) throws
}
}
+ private KafkaSupervisorTuningConfig getTuningConfig()
+ {
+ return getTuningConfig(null);
+ }
+
+ /**
+ * Use this method to create a {@link KafkaSupervisorTuningConfig} with
custom thread count.
+ *
+ * @param threadCount the number of threads to use, or null to imitate
default settings.
+ */
+ private KafkaSupervisorTuningConfig getTuningConfig(@Nullable Integer
threadCount)
+ {
+ return new KafkaSupervisorTuningConfig(
+ null,
+ 1000,
+ null,
+ null,
+ 50000,
+ null,
+ new Period("P1Y"),
+ null,
+ null,
+ null,
+ false,
+ null,
+ false,
+ null,
+ threadCount,
+ TEST_CHAT_RETRIES,
+ TEST_HTTP_TIMEOUT,
+ TEST_SHUTDOWN_TIMEOUT,
+ null,
+ null,
+ null,
+ null,
+ 10,
+ null,
+ null
+ );
+ }
+
+ private KafkaSupervisorIOConfig getIOConfig()
+ {
+ return getIOConfig(1, null);
+ }
+
+ private KafkaSupervisorIOConfig getIOConfig(int taskCount)
+ {
+ return getIOConfig(taskCount, null);
+ }
+
+ private KafkaSupervisorIOConfig getIOConfig(AutoScalerConfig
autoScalerConfig)
+ {
+ return getIOConfig(1, autoScalerConfig);
+ }
Review Comment:
I think these are unnecessary, just use the method with two args.
##########
extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisorTest.java:
##########
@@ -5209,6 +5283,97 @@ private void addMoreEvents(int numEventsPerPartition,
int num_partitions) throws
}
}
+ private KafkaSupervisorTuningConfig getTuningConfig()
+ {
+ return getTuningConfig(null);
+ }
+
+ /**
+ * Use this method to create a {@link KafkaSupervisorTuningConfig} with
custom thread count.
+ *
+ * @param threadCount the number of threads to use, or null to imitate
default settings.
+ */
+ private KafkaSupervisorTuningConfig getTuningConfig(@Nullable Integer
threadCount)
+ {
+ return new KafkaSupervisorTuningConfig(
+ null,
+ 1000,
+ null,
+ null,
+ 50000,
+ null,
+ new Period("P1Y"),
+ null,
+ null,
+ null,
+ false,
+ null,
+ false,
+ null,
+ threadCount,
+ TEST_CHAT_RETRIES,
+ TEST_HTTP_TIMEOUT,
+ TEST_SHUTDOWN_TIMEOUT,
+ null,
+ null,
+ null,
+ null,
+ 10,
+ null,
+ null
+ );
+ }
+
+ private KafkaSupervisorIOConfig getIOConfig()
+ {
+ return getIOConfig(1, null);
+ }
+
+ private KafkaSupervisorIOConfig getIOConfig(int taskCount)
+ {
+ return getIOConfig(taskCount, null);
+ }
+
+ private KafkaSupervisorIOConfig getIOConfig(AutoScalerConfig
autoScalerConfig)
+ {
+ return getIOConfig(1, autoScalerConfig);
+ }
+
+ /**
+ * Use this method to create a {@link KafkaSupervisorIOConfig} with custom
properties.
+ */
+ private KafkaSupervisorIOConfig getIOConfig(
Review Comment:
```suggestion
private KafkaSupervisorIOConfig createSupervisorIOConfig(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
