gianm opened a new pull request, #18168: URL: https://github.com/apache/druid/pull/18168
Both toolchests were returning "new DefaultQueryMetrics" from their "makeMetrics" method. This caused two issues: 1) The "query(query)" method was not called, so standard dimensions like dataSource, type, etc, were not included. 2) Site-specific DefaultQueryMetrics customizations were not respected. I think this only really has an impact for the `windowOperator` query, because I don't think `QueryLogicCompat` can be a top-level toolchest (so it won't be used for metrics emission). I adjusted both anyway though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
