vtlim commented on PR #549: URL: https://github.com/apache/druid-website-src/pull/549#issuecomment-2998090128
Couple of suggestions on the README (can't comment directly bc my browser can't handle) Current line > When publishing, build the site and then copy the contents of `build` to the `druid-website` repo. Make sure you do not accidentally delete the contents of `docs` in `druid-website`. Suggestion (bold to show the diff): > When publishing, build the site and then copy the contents of `build` to the `druid-website` repo. **Don't delete the existing `docs` content in `druid-website` since it also contains previous build versions.** --- Current line > 6. Use the contents of `build` to make a PR to `https://github.com/apache/druid-website` (either the `asf-staging` branch or the `asf-site` branch). Make sure you do not delete the previous Druid versions in the `docs` folder in `druid-website`. Suggestion -- numbering should be **5** --- Otherwise build process LGTM -- built successfully, previewed changes, verified `latest` and versioned path -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
