kgyrtkirk commented on code in PR #18154:
URL: https://github.com/apache/druid/pull/18154#discussion_r2163170973
##########
processing/src/test/java/org/apache/druid/query/aggregation/SerializablePairLongStringComplexMetricSerdeTest.java:
##########
@@ -69,7 +69,7 @@ public void testLargeString() throws Exception
assertExpected(ImmutableList.of(new SerializablePairLongString(
100L,
randomStringUtils.randomAlphanumeric(2 * 1024 * 1024)
- )), 2097182, 2103140);
+ )), 2097182, 2103139);
Review Comment:
I was also worried when I've first saw these tests breaking :)
but its due to the fact that the random algorithm was altered in
`commons-lang3:3.15.0`.
The reason that matters is that `RandomStringUtils` uses
`org.apache.commons.lang3.RandomStringUtils` internally.
Prior to `<3.15.0` these tests pass with all the other dep updates and
require these updates afterwards.
https://commons.apache.org/proper/commons-lang/changes-report.html#a3.15.0
```
Reimplement RandomUtils and RandomStringUtils on top of
SecureRandom#getInstanceStrong() #1235. Thanks to Gary Gregory, Henri Yandell,
Fabrice Benhamouda.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
