kfaraz commented on code in PR #18178:
URL: https://github.com/apache/druid/pull/18178#discussion_r2175435186
##########
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaRecordSupplier.java:
##########
@@ -63,6 +63,17 @@
public class KafkaRecordSupplier implements
RecordSupplier<KafkaTopicPartition, Long, KafkaRecordEntity>
{
+ // by default, we reject all URLs for OAuthBearer authentication
+ // CVE ref: https://www.cve.org/CVERecord?id=CVE-2025-27817
+ // Upgrade kafka dependencies to 4.x to remove the need for this static block
+ static {
+ final String allowedSaslOauthbearerUrlsConfig =
"org.apache.kafka.sasl.oauthbearer.allowed.urls";
+ String allowedUrlsProp =
System.getProperty(allowedSaslOauthbearerUrlsConfig);
+ if (allowedUrlsProp == null) {
+ System.setProperty(allowedSaslOauthbearerUrlsConfig, "notallowed");
+ }
+ }
Review Comment:
I wonder if we should just put this in `AuthorizationUtils` even though it
doesn't pertain to core Druid and only extensions, just so we can have it in a
common place with adequate javadocs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
