FrankChen021 commented on code in PR #18159:
URL: https://github.com/apache/druid/pull/18159#discussion_r2176292345


##########
extensions-core/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/common/DruidK8sConstants.java:
##########
@@ -47,5 +47,10 @@ public class DruidK8sConstants
   public static final String DRUID_LABEL_PREFIX = "druid.";
   public static final String BASE_TEMPLATE_NAME = "base";
   public static final long MAX_ENV_VARIABLE_KBS = 130048; // 127 KB
-  static final Predicate<Throwable> IS_TRANSIENT = e -> e instanceof 
KubernetesResourceNotFoundException;
+
+  public static final ImmutableList<String> 
BLACKLISTED_PEON_POD_ERROR_MESSAGES = ImmutableList.of(
+      // Catches limit to ratio constraint: 
https://github.com/kubernetes/kubernetes/blob/3e39d1074fc717a883aaf57b966dd7a06dfca2ec/plugin/pkg/admission/limitranger/admission.go#L359
+      // {resource} max limit to request ratio per Container is {value}, but 
provided ratio is {value}
+      "max limit to request ratio"

Review Comment:
   there might be some other cases that PODs will not be created sucecssfully 
such as quota exceeds



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to