github-advanced-security[bot] commented on code in PR #18189:
URL: https://github.com/apache/druid/pull/18189#discussion_r2179790076
##########
server/src/main/java/org/apache/druid/query/lookup/LookupReferencesManager.java:
##########
@@ -471,24 +476,37 @@
@Nullable
private Map<String, LookupExtractorFactoryContainer>
tryGetLookupListFromCoordinator(String tier)
+ throws IOException, InterruptedException
{
- try {
- return
FutureUtils.getUnchecked(coordinatorClient.fetchLookupsForTier(tier), true);
+ final StringFullResponseHolder response = fetchLookupsForTier(tier);
+ if (response.getStatus().equals(HttpResponseStatus.NOT_FOUND)) {
+ LOG.warn("No lookups found for tier [%s], response [%s]", tier,
response);
Review Comment:
## Use of default toString()
Default toString(): StringFullResponseHolder inherits toString() from
Object, and so is not suitable for printing.
[Show more
details](https://github.com/apache/druid/security/code-scanning/2836)
##########
server/src/test/java/org/apache/druid/query/lookup/LookupReferencesManagerTest.java:
##########
@@ -80,29 +81,50 @@
);
container = new LookupExtractorFactoryContainer("v0",
lookupExtractorFactory);
mapper.registerSubtypes(MapLookupExtractorFactory.class);
+ String temporaryPath = temporaryFolder.newFolder().getAbsolutePath();
Review Comment:
## Unread local variable
Variable 'String temporaryPath' is never read.
[Show more
details](https://github.com/apache/druid/security/code-scanning/2445)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
